dstandish commented on code in PR #46248:
URL: https://github.com/apache/airflow/pull/46248#discussion_r1941703951
##########
airflow/models/backfill.py:
##########
@@ -288,32 +280,42 @@ def _create_backfill_dag_run(
)
return
dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session)
- dr = dag.create_dagrun(
- run_id=dag.timetable.generate_run_id(
- run_type=DagRunType.BACKFILL_JOB,
+ try:
+ dr = dag.create_dagrun(
+ run_id=dag.timetable.generate_run_id(
+ run_type=DagRunType.BACKFILL_JOB,
+ logical_date=info.logical_date,
+ data_interval=info.data_interval,
+ ),
logical_date=info.logical_date,
data_interval=info.data_interval,
- ),
- logical_date=info.logical_date,
- data_interval=info.data_interval,
- run_after=info.run_after,
+ run_after=info.run_after,
conf=dag_run_conf,
- run_type=DagRunType.BACKFILL_JOB,
- triggered_by=DagRunTriggeredByType.BACKFILL,
- dag_version=dag_version,
- state=DagRunState.QUEUED,
- start_date=timezone.utcnow(),
- backfill_id=backfill_id,
- session=session,
- )
- session.add(
- BackfillDagRun(
+ run_type=DagRunType.BACKFILL_JOB,
+ triggered_by=DagRunTriggeredByType.BACKFILL,
+ dag_version=dag_version,
+ state=DagRunState.QUEUED,
+ start_date=timezone.utcnow(),
backfill_id=backfill_id,
- dag_run_id=dr.id,
- sort_ordinal=backfill_sort_ordinal,
- logical_date=info.logical_date,
+ session=session,
)
- )
+ session.add(
+ BackfillDagRun(
+ backfill_id=backfill_id,
+ dag_run_id=dr.id,
+ sort_ordinal=backfill_sort_ordinal,
+ logical_date=info.logical_date,
+ )
+ )
+ except IntegrityError:
+ log.info(
Review Comment:
if the insert fails, we should probably still create the BDR record
we would need to do it after the rollback (which would roll back the BDR
insert)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
