uranusjr commented on code in PR #46398:
URL: https://github.com/apache/airflow/pull/46398#discussion_r1942548706


##########
airflow/api/common/trigger_dag.py:
##########
@@ -84,7 +84,10 @@ def _trigger_dag(
 
     data_interval = 
dag.timetable.infer_manual_data_interval(run_after=coerced_logical_date)
     run_id = run_id or dag.timetable.generate_run_id(
-        run_type=DagRunType.MANUAL, logical_date=coerced_logical_date, 
data_interval=data_interval
+        run_type=DagRunType.MANUAL,
+        logical_date=coerced_logical_date,
+        data_interval=data_interval,
+        run_after=data_interval.end,

Review Comment:
   Oh yeah you’re right. This should do `coerced_logical_date or 
timezone.utcnow()` (as currently implemented, `coerced_logical_date` can never 
be None, but it will be when everything is finished).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to