Lee-W commented on code in PR #46415:
URL: https://github.com/apache/airflow/pull/46415#discussion_r1942548308
##########
newsfragments/46415.significant.rst:
##########
@@ -0,0 +1,16 @@
+Legacy signature for operator link is removed.
+
+``BaseOperatorLink.get_link`` used to accept execution date as an argument.
This
+has been changed to accept ``ti_key`` to identify a task instance instead. The
+old signature, supported at runtime for compatibility, has been removed.
+
+* Types of change
+
+ * [x] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
Review Comment:
Will we move it to task_sdk. I though we're to avoid users access to
`airflow.models`
##########
newsfragments/46415.significant.rst:
##########
@@ -0,0 +1,16 @@
+Legacy signature for operator link is removed.
+
+``BaseOperatorLink.get_link`` used to accept execution date as an argument.
This
+has been changed to accept ``ti_key`` to identify a task instance instead. The
+old signature, supported at runtime for compatibility, has been removed.
+
+* Types of change
+
+ * [x] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
Review Comment:
```suggestion
* [x] Code interface changes
* Migration rules needed
* ruff
* AIR302
* [ ] Signature of
``airflow.models.baseoperatorlink.BaseOperatorLink.get_link`` changed
.. detailed in
https://github.com/apache/airflow/pull/46415#issuecomment-2636186625
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
