potiuk commented on code in PR #43383:
URL: https://github.com/apache/airflow/pull/43383#discussion_r1944255139
##########
providers/standard/tests/provider_tests/standard/utils/test_python_virtualenv.py:
##########
@@ -191,26 +192,29 @@ def
test_should_create_virtualenv_with_extra_packages_uv(self, mock_execute_in_s
["uv", "pip", "install", "--python", "/VENV/bin/python",
"apache-beam[gcp]"]
)
- def test_remove_task_decorator(self):
- py_source = '@task.virtualenv(serializer="dill")\ndef f():\nimport
funcsigs'
- res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "def f():\nimport funcsigs"
-
- def test_remove_decorator_no_parens(self):
- py_source = "@task.virtualenv\ndef f():\nimport funcsigs"
- res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "def f():\nimport funcsigs"
-
- def test_remove_decorator_including_comment(self):
- py_source = "@task.virtualenv\ndef f():\n# @task.virtualenv\nimport
funcsigs"
- res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "def f():\n# @task.virtualenv\nimport funcsigs"
-
- def test_remove_decorator_nested(self):
- py_source = "@foo\[email protected]\n@bar\ndef f():\nimport funcsigs"
- res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "@foo\n@bar\ndef f():\nimport funcsigs"
+ @pytest.mark.parametrize(
+ "decorators, expected_decorators",
+ [
+ (["@task.virtualenv"], []),
+ (["@task.virtualenv()"], []),
+ (['@task.virtualenv(serializer="dill")'], []),
+ (["@foo", "@task.virtualenv", "@bar"], ["@foo", "@bar"]),
+ (["@foo", "@task.virtualenv()", "@bar"], ["@foo", "@bar"]),
+ ],
+ ids=["without_parens", "parens", "with_args", "nested_without_parens",
"nested_with_parens"],
+ )
+ def test_remove_task_decorator(self, decorators: list[str],
expected_decorators: list[str]):
+ decorator = "\n".join(decorators)
Review Comment:
Yep. Agree :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
