ashb commented on code in PR #46032:
URL: https://github.com/apache/airflow/pull/46032#discussion_r1944529176
##########
task_sdk/src/airflow/sdk/definitions/xcom_arg.py:
##########
@@ -354,17 +332,16 @@ def concat(self, *others: XComArg) -> ConcatXComArg:
raise ValueError("cannot concatenate non-return XCom")
return super().concat(*others)
- # TODO: Task-SDK: Remove session argument once everything is ported over
to Task SDK
- def resolve(
- self, context: Mapping[str, Any], session: Session | None = None, *,
include_xcom: bool = True
- ) -> Any:
+ def resolve(self, context: Mapping[str, Any]) -> Any:
ti = context["ti"]
task_id = self.operator.task_id
- map_indexes = context.get("_upstream_map_indexes", {}).get(task_id)
+
+ if self.operator.is_mapped:
+ return LazyXComSequence[Any](xcom_arg=self, ti=ti)
result = ti.xcom_pull(
task_ids=task_id,
- map_indexes=map_indexes,
+ # map_indexes=map_indexes,
Review Comment:
(We want to use the default in ti.xcom_pull of looking at ti.map_index) This
was a bug from the previous PR that nothing hit but now does)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
