potiuk commented on PR #46140: URL: https://github.com/apache/airflow/pull/46140#issuecomment-2643216498
> > Ok. I think I know what the problem was. I pushed a fixup. The problem was that `uv run` to run the pytest command creates automatically a complete local venv - which is not needed (and a bit harmful if some libraries cannot be installed). But we already have an environemtn there with all the libraries needed, so we should use that one, rather than create a new one > > That’s really impressive to find out! I’ve been encountering the same traceback since my first push and couldn’t figure it out. > > Should we replace `"uv", "run"` in other scripts, even though the only occurrence right now is `"uv", "run", "airflow", "db", "reset", "--yes"` in `initialize_virtualenv.py`? Or is it a good idea to add a `pre-commit` check to prevent passing `"uv", "run"` to `subprocess.run`? No. It's really ok and "intended" everywhere. In here we create a k8s env specifically to run the tests, but with `uv run` we were not using it effectively. In other places `uv run` makes sense actually - there we **expect** airflow venv to be actually created - maybe we will have to tweak it a bit so problematic dependencies that we might have difficulty to build should be excluded by default - but we will see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
