sunank200 commented on code in PR #46398:
URL: https://github.com/apache/airflow/pull/46398#discussion_r1948896952
##########
airflow/models/baseoperator.py:
##########
@@ -628,7 +628,11 @@ def run(
# This is _mostly_ only used in tests
dr = DagRun(
dag_id=self.dag_id,
- run_id=DagRun.generate_run_id(DagRunType.MANUAL,
info.logical_date),
+ run_id=DagRun.generate_run_id(
+ DagRunType.MANUAL,
+ info.logical_date,
Review Comment:
I have changed it here: https://github.com/apache/airflow/pull/46616
##########
airflow/models/dagrun.py:
##########
@@ -621,10 +621,12 @@ def find_duplicate(cls, dag_id: str, run_id: str, *,
session: Session = NEW_SESS
return session.scalars(select(cls).where(cls.dag_id == dag_id,
cls.run_id == run_id)).one_or_none()
@staticmethod
- def generate_run_id(run_type: DagRunType, logical_date: datetime) -> str:
+ def generate_run_id(
+ run_type: DagRunType, logical_date: datetime | None, run_after:
datetime | None = None
Review Comment:
I have changed it here: https://github.com/apache/airflow/pull/46616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
