jedcunningham commented on code in PR #46627: URL: https://github.com/apache/airflow/pull/46627#discussion_r1949469463
########## airflow/api_fastapi/core_api/routes/public/login.py: ########## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from fastapi import Request, status +from fastapi.responses import RedirectResponse + +from airflow.api_fastapi.common.router import AirflowRouter +from airflow.api_fastapi.core_api.openapi.exceptions import create_openapi_http_exception_doc + +login_router = AirflowRouter(tags=["Login"], prefix="/login") + + +@login_router.get( + "", + responses=create_openapi_http_exception_doc([status.HTTP_308_PERMANENT_REDIRECT]), +) +def login( + request: Request, +) -> RedirectResponse: + """Redirect to the login URL depending on the AuthManager configured.""" + return RedirectResponse(request.app.state.auth_manager.get_url_login(), status_code=308) Review Comment: Should we be using 307 instead? I feel like we should still have the browser hit us for the redirect fresh each time vs caching it - what if the authmananger/config is changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
