Lee-W commented on code in PR #46460:
URL: https://github.com/apache/airflow/pull/46460#discussion_r1952207801
##########
airflow/models/dag.py:
##########
@@ -928,21 +927,21 @@ def get_task_instances_before(
corresponding to any DagRunType. It can have less if there are
less than ``num`` scheduled DAG runs before ``base_date``.
"""
- logical_dates: list[Any] = session.execute(
- select(DagRun.logical_date)
+ run_after_cols: list[Any] = session.execute(
+ select(DagRun.run_after)
Review Comment:
After the latest revert and testing, seems to work fine 🤔 resolve this one
##########
airflow/models/dag.py:
##########
@@ -1051,14 +1050,14 @@ def _get_task_instances(
if run_id:
tis = tis.where(TaskInstance.run_id == run_id)
if start_date:
- tis = tis.where(DagRun.logical_date >= start_date)
+ tis = tis.where(DagRun.run_after >= start_date)
if task_ids is not None:
tis = tis.where(TaskInstance.ti_selector_condition(task_ids))
# This allows allow_trigger_in_future config to take affect, rather
than mandating exec_date <= UTC
if end_date or not self.allow_future_exec_dates:
end_date = end_date or timezone.utcnow()
- tis = tis.where(DagRun.logical_date <= end_date)
+ tis = tis.where(DagRun.run_after <= end_date)
Review Comment:
After the latest revert and testing, seems to work fine 🤔 resolve this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
