pierrejeambrun commented on code in PR #46666:
URL: https://github.com/apache/airflow/pull/46666#discussion_r1952357219
##########
airflow/ui/src/components/TrendCountChart.tsx:
##########
@@ -35,7 +35,7 @@ import { useColorMode } from "src/context/colorMode";
ChartJS.register(CategoryScale, LinearScale, PointElement, LineElement,
Filler, Tooltip);
-export type ChartEvent = { timestamp: string };
+export type ChartEvent = { timestamp: string | null };
Review Comment:
This will work because in the following code everything will end up being
`NaN` trying to compute things on the null value.
I think we should explicitely handle the null case, line 45.
```
if (event.timestamp === null) {
return;
}
```
Event will be counted but not have time position because we don't know when
the event appeared, which I think is correct:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
