potiuk commented on code in PR #45060: URL: https://github.com/apache/airflow/pull/45060#discussion_r1953065404
########## providers/fab/src/airflow/providers/fab/www/static/dist/airflowDefaultTheme.9afce1aedbae94358039.css: ########## Review Comment: Yeah - that's a bit of the question: * should we generate the dist files at packaging time * or maybe we should generate them as pre-commit Both have pros and cons, but since FAB is the only provider that needs those, making a "common" build packaging extra step is complicating things - checking in the compiled javascript is a bit redundant, and while it would be very bad for Airflow (as it would require to recreate and replace the generated files every time the sources change - which means "often" - in case of FAB, I assume the number of times the FAB assets will have to be regenerated are very, very rare, so pre-commit is much more viable approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
