lennartkats-db commented on issue #46569: URL: https://github.com/apache/airflow/issues/46569#issuecomment-2656635035
@pankajkoti > if the fix is going to take longer, if you'd really like to, then you could create a revert PR for the original PR +1 speaking for the Databricks eng team, I'd be supportive to do a revert while the fix is being prepared. I don't want to hold the train and I'm super appreciative of the volunteers that keep the train going 🙏 To recap my understanding of the issue at hand: * ✅ https://github.com/apache/airflow/issues/46569 is adding named parameters + documentation for using serverless with Databricks. Super helpful. * ✅ Before this PR, users could only use serverless by directly passing JSON objects to the task type. This was inconvenient and hard to discover. * ✋ We shouldn't release this PR yet before the fix proposed by @HariGS-DB. Users should always pass an environment when using serverless. This is not yet enforced by the API but will be enforced in the future. A client-side check would avoid future breakages and would ensure that users always pick an environment version (so the API doesn't default to the very oldest version). * ✅ I'd expect this fix **won't be a "breaking change" for current users** who just pass raw JSON. But it is arguably "breaking change" for the new named parameters PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
