ashb commented on code in PR #46777:
URL: https://github.com/apache/airflow/pull/46777#discussion_r1956681449
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -2009,7 +2010,7 @@ def _find_zombies(self, *, session: Session) -> list[TI]:
.join(DM, TI.dag_id == DM.dag_id)
.where(
TI.state.in_((TaskInstanceState.RUNNING,
TaskInstanceState.RESTARTING)),
- TI.last_heartbeat_at < limit_dttm,
+ coalesce(TI.last_heartbeat_at, TI.updated_at) < limit_dttm,
Review Comment:
The downside with doing this is that update_at can be set for other reasons,
it could be set by the scheduler for instance, so this _might_ in some
circumstances keep a task alive longer than it should (but not indefinitely, it
would like be a one-time only bump if at all)
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
