potiuk commented on code in PR #46608:
URL: https://github.com/apache/airflow/pull/46608#discussion_r1957075921
##########
tests/always/test_project_structure.py:
##########
@@ -56,48 +53,86 @@ def assert_file_contains(self, filename: pathlib.Path,
pattern: str):
def test_providers_modules_should_have_tests(self):
"""
- Assert every module in /providers/src/airflow/providers has a
corresponding test_ file in providers/providers.
+ Assert every module in /providers/ has a corresponding test_ file in
providers/providers.
"""
# The test below had a but for quite a while and we missed a lot of
modules to have tess
# We should make sure that one goes to 0
+ # TODO(potiuk) - check if that test actually tests something
OVERLOOKED_TESTS = [
- "providers/tests/amazon/aws/executors/batch/test_boto_schema.py",
-
"providers/tests/amazon/aws/executors/batch/test_batch_executor_config.py",
- "providers/tests/amazon/aws/executors/batch/test_utils.py",
- "providers/tests/amazon/aws/executors/ecs/test_boto_schema.py",
-
"providers/tests/amazon/aws/executors/ecs/test_ecs_executor_config.py",
- "providers/tests/amazon/aws/executors/ecs/test_utils.py",
-
"providers/tests/amazon/aws/executors/utils/test_base_config_keys.py",
- "providers/tests/amazon/aws/operators/test_emr.py",
- "providers/tests/amazon/aws/operators/test_sagemaker.py",
- "providers/tests/amazon/aws/sensors/test_emr.py",
- "providers/tests/amazon/aws/sensors/test_sagemaker.py",
- "providers/tests/amazon/aws/test_exceptions.py",
- "providers/tests/amazon/aws/triggers/test_step_function.py",
- "providers/tests/amazon/aws/utils/test_rds.py",
- "providers/tests/amazon/aws/utils/test_sagemaker.py",
- "providers/tests/amazon/aws/waiters/test_base_waiter.py",
- "providers/tests/apache/drill/operators/test_drill.py",
- "providers/tests/apache/druid/operators/test_druid_check.py",
- "providers/tests/apache/hdfs/hooks/test_hdfs.py",
- "providers/tests/apache/hdfs/log/test_hdfs_task_handler.py",
- "providers/tests/apache/hdfs/sensors/test_hdfs.py",
- "providers/tests/apache/hive/plugins/test_hive.py",
- "providers/tests/celery/executors/test_celery_executor_utils.py",
- "providers/tests/celery/executors/test_default_celery.py",
- "providers/tests/cloudant/test_cloudant_fake.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/batch/test_batch_executor_config.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/batch/test_boto_schema.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/batch/test_utils.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/ecs/test_boto_schema.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/ecs/test_ecs_executor_config.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/ecs/test_utils.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/executors/utils/test_base_config_keys.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/operators/test_emr.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/operators/test_sagemaker.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/sensors/test_emr.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/sensors/test_sagemaker.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/test_exceptions.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/triggers/test_step_function.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/utils/test_rds.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/utils/test_sagemaker.py",
+
"providers/amazon/tests/provider_tests/amazon/aws/waiters/test_base_waiter.py",
+
"providers/amazon/tests/provider_tests/amazon/test_version_compat.py",
+
"providers/apache/hdfs/tests/provider_tests/apache/hdfs/hooks/test_hdfs.py",
+
"providers/apache/hdfs/tests/provider_tests/apache/hdfs/log/test_hdfs_task_handler.py",
+
"providers/apache/hdfs/tests/provider_tests/apache/hdfs/sensors/test_hdfs.py",
+
"providers/apache/hive/tests/provider_tests/apache/hive/plugins/test_hive.py",
+
"providers/celery/tests/provider_tests/celery/executors/test_celery_executor_utils.py",
+
"providers/celery/tests/provider_tests/celery/executors/test_default_celery.py",
+
"providers/celery/tests/provider_tests/celery/test_version_compat.py",
+
"providers/cloudant/tests/provider_tests/cloudant/test_cloudant_fake.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/executors/test_kubernetes_executor_types.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/executors/test_kubernetes_executor_utils.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/operators/test_kubernetes_pod.py",
+
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_exceptions.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_k8s_model.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_kube_client.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_kube_config.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_python_kubernetes_script.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_secret.py",
+
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/test_version_compat.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/triggers/test_kubernetes_pod.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/utils/test_delete_from.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/utils/test_k8s_hashlib_wrapper.py",
"providers/cncf/kubernetes/tests/provider_tests/cncf/kubernetes/utils/test_xcom_sidecar.py",
+
"providers/common/compat/tests/provider_tests/common/compat/lineage/test_entities.py",
Review Comment:
This check was not working after the move to "providers" folder. It starts
to work back and I had to add all the modules that have no corresponding tests.
We might want to rethink how this works (but that would be a separate
discussion/PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
