mik-laj commented on a change in pull request #6279: [AIRFLOW-5609][WIP] Add
MLEngine models operators
URL: https://github.com/apache/airflow/pull/6279#discussion_r332240000
##########
File path: airflow/gcp/hooks/mlengine.py
##########
@@ -275,3 +275,19 @@ def get_model(self, project_id: str, model_name: str) ->
Optional[Dict]:
self.log.error('Model was not found: %s', e)
return None
raise
+
+ def delete_model(self, project_id: str, model_name: str) -> None:
Review comment:
Here we need a fallback for project id, but I prefer to do it in a separate
PR for whole integration. I prefer to maintain uniformity at the expense of
functionality
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
