bugraoz93 commented on code in PR #46799:
URL: https://github.com/apache/airflow/pull/46799#discussion_r1957299766
##########
airflow/cli/commands/remote_commands/variable_command.py:
##########
@@ -86,6 +86,14 @@ def variables_import(args, session):
var_json = json.load(varfile)
except JSONDecodeError:
raise SystemExit("Invalid variables file.")
+ var_descriptions = {}
+ if args.description_file and os.path.exists(args.description_file):
Review Comment:
Thanks for the changes! Why do we make this a new file rather than including
into the current one and reading accordingly? I believe creating two files with
matching order is a bit harder than adding them into the same file. This would
also require export functionality to conform. Soon this will be integrated with
the API so a single file rather easier to integrate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
