jscheffl commented on code in PR #46810:
URL: https://github.com/apache/airflow/pull/46810#discussion_r1957396239
##########
contributing-docs/11_provider_packages.rst:
##########
@@ -174,13 +174,9 @@ there where you should add and remove dependencies for
providers (following by r
``update-providers-dependencies`` pre-commit to synchronize the dependencies
with ``pyproject.toml``
of Airflow).
-The old ``provider.yaml`` file is compliant with the schema that is available
in
+The ``provider.yaml`` file is compliant with the new schema that is available
in
Review Comment:
"new" is realtive. Right after merge this is out-dated. It is the "current"
structure. I'd propose to remove the term "new".
##########
providers/MANAGING_PROVIDERS_LIFECYCLE.rst:
##########
@@ -64,63 +62,67 @@ triggers (and the list changes continuously).
GIT apache/airflow/
└── providers/
- ├── src/
- │ └── airflow/
- │ └── providers/<NEW_PROVIDER>/
- │ ├── __init__.py
- │ ├── executors/
- │ │ ├── __init__.py
- │ │ └── *.py
- │ ├── hooks/
- │ │ ├── __init__.py
- │ │ └── *.py
- │ ├── notifications/
- │ │ ├── __init__.py
- │ │ └── *.py
- │ ├── operators/
- │ │ ├── __init__.py
- │ │ └── *.py
- │ ├── transfers/
- │ │ ├── __init__.py
- │ │ └── *.py
- │ └── triggers/
- │ ├── __init__.py
- │ └── *.py
- └── tests/
- ├── <NEW_PROVIDER>/
- | ├── __init__.py
- | ├── executors/
- | │ ├── __init__.py
- | │ └── test_*.py
- | ├── hooks/
- | │ ├── __init__.py
- | │ └── test_*.py
- | ├── notifications/
- | │ ├── __init__.py
- | │ └── test_*.py
- | ├── operators/
- | │ ├── __init__.py
- | │ └── test_*.py
- | ├── transfers/
- | │ ├── __init__.py
- | │ └── test_*.py
- | └── triggers/
- | ├── __init__.py
- | └── test_*.py
- └── system/<NEW_PROVIDER>/
- ├── __init__.py
- └── example_*.py
-
-.. note::
- The above structure is work in progress and subject to change till Task
SDK feature is complete.
+ ├── pyproject.toml
+ ├── provider.yaml
Review Comment:
The provider.toml|yaml need to reside _within_ the providers folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
