uranusjr commented on code in PR #46633:
URL: https://github.com/apache/airflow/pull/46633#discussion_r1957689306
##########
tests/operators/test_trigger_dagrun.py:
##########
@@ -41,6 +40,7 @@
pytestmark = pytest.mark.db_test
DEFAULT_DATE = datetime(2019, 1, 1, tzinfo=timezone.utc)
+DEFAULT_RUN_ID = f"{DagRunType.MANUAL}__{DEFAULT_DATE.isoformat()}"
Review Comment:
Probably doesn’t matter since we don’t parse the run ID, this is just a
string to Airflow. Maybe let’s just use a string like `test_run_id` instead.
##########
tests/operators/test_trigger_dagrun.py:
##########
@@ -41,6 +40,7 @@
pytestmark = pytest.mark.db_test
DEFAULT_DATE = datetime(2019, 1, 1, tzinfo=timezone.utc)
+DEFAULT_RUN_ID = f"{DagRunType.MANUAL}__{DEFAULT_DATE.isoformat()}"
Review Comment:
Probably doesn’t matter since we don’t parse the run ID, this is just a
string to Airflow. Maybe let’s just use a string like `"test_run_id"` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
