jason810496 commented on issue #46657:
URL: https://github.com/apache/airflow/issues/46657#issuecomment-2663163563

   > logs endpoint currently has to load log files from multiple sources and 
interleave/sort them by date (worker, triggerer, scheduler can all produce logs 
for a TI) so it's not as stright forward as just "serve up this one file" sadly.
   
   Yes, I have looked into the part you mentioned before. I believe this is not 
the main issue and is unrelated to this specific discussion. The key aspect 
here is **changing how the `get_log` API reads from `task_log_reader`**.  
   
   
https://github.com/apache/airflow/blob/main/airflow/api_fastapi/core_api/routes/public/log.py#L138-L146
   
   > So while I too like `application/x-ndjson` I don't think it's a simple 
matter of just changing it to that.
   
   From my perspective, this shouldn't be a major issue (at least from the API 
side; I'm unsure about the UI side). The `task_log_reader.read_log_stream` 
method is actually a generator, which is also how the legacy UI retrieves logs 
from the `text/plain` log response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to