vincbeck commented on issue #45936: URL: https://github.com/apache/airflow/issues/45936#issuecomment-2663522774
> I think `users` command should only be visible when FAB auth manager is set. possibly it's FAB provider that should contribute it when FAB provider is set as Auth Manager. Yes this is the case today. The command `airflow users` is provided by the FAB auth manager. As a result, if FAB auth manager is set as auth manager in the airflow env, the command `airflow users` works. If not, the command `airflow users` does not exist. The problem is, the command `airflow users` seems to be referred in many places (documentation, scripts etc) across Airflow codebase assuming this command exists but this might not be true if FAB auth manager is not set in the environment. I think there are multiple questions: - Should we keep having FAB auth manager as default auth manager in Breeze? Simple auth manager could be used instead. We might have the conversation about it some times ago but I dont quite remember the decision we took. But as far as I remember, the main motivation of building simple auth manager was to use it as default in Breeze. If we go down that path, we should remove all occurrences of `airflow users` in breeze. - I think keeping FAB auth manager as default auth manager in Airflow makes the most sense today because we do not have an alternative. However, in documentation, we should probably update it and everytime `airflow users` is mentioned, we probably should mention that this command exists only if FAB auth manager is used in the env. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
