bugraoz93 commented on code in PR #46839: URL: https://github.com/apache/airflow/pull/46839#discussion_r1960719547
########## tests/auth/managers/simple/routes/test_login.py: ########## @@ -0,0 +1,82 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from unittest.mock import patch + +import pytest + +from tests_common.test_utils.config import conf_vars + +TEST_USER_1 = "test1" +TEST_ROLE_1 = "viewer" +TEST_USER_2 = "test2" +TEST_ROLE_2 = "admin" + + [email protected]_test +class TestLogin: Review Comment: Make sense! Separated the service layer test and route test. Service one calls the service and route one using the `test_client`. I ended up with 4 tests though because mocking is a bit weird due to LoginResponse normally not returning HTTPException but raising them. It should be fine to have them separate ########## airflow/auth/managers/simple/services/login.py: ########## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from fastapi import HTTPException, status + +from airflow.api_fastapi.app import get_auth_manager +from airflow.auth.managers.simple.datamodels.login import LoginBody, LoginResponse +from airflow.auth.managers.simple.simple_auth_manager import SimpleAuthManager +from airflow.auth.managers.simple.user import SimpleAuthManagerUser +from airflow.configuration import conf +from airflow.utils.jwt_signer import JWTSigner + + +class Login: Review Comment: Renamed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
