amoghrajesh commented on PR #46860: URL: https://github.com/apache/airflow/pull/46860#issuecomment-2667560959
> > The interface for "CommandType" has been changed to accept either a sequence string or workloads.ExecuteTask which will be useful for KubernetesExecutor. > > We shouldn't really be changing it to be a union, we want to make it a totally different interface -- what I did in CeleryExecutor was this: > > https://github.com/apache/airflow/blob/b715909ef1caf499b52ba86e14d8c5eb7859ecde/airflow/jobs/scheduler_job_runner.py#L635-L640 > > So we should instead add a new impl like this > > https://github.com/apache/airflow/blob/b715909ef1caf499b52ba86e14d8c5eb7859ecde/providers/celery/src/airflow/providers/celery/executors/celery_executor.py#L507-L513 > > And we can have different paths for using the KE on v2 vs for v3 Yeah you are right, I already implemented the change you suggested from the very beginning. But looks like for some reason I got driven to make this change, probably it was mypy that made me do it! Fixing it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
