ashb commented on PR #46929:
URL: https://github.com/apache/airflow/pull/46929#issuecomment-2674202252
Allowing None/not set on fetch is okay. Set def shouldn't accept None nor
empty string though.
We'll need to make sure that we handle `key=None` specially in the TaskSDK
client though -- that should evalute to _ not passing_ the key argument -- but
that might need a new API end point to allow that, as the URL is currently
`/xcoms/{dag_id}/{run_id}/{task_id}/{key}` -- and we can't pass `None` there,
as it has to be a string.
So to do the `key=None` = get all xcom values properly we would need to add
a list endpoint `/xcoms/{dag_id}/{run_id}/{task_id}/` that returns the key
names found, and then client side we iterate over each value individually (as
we didn't have a multiget on purpose, deciding to do it client side instead).
But that is a separate PR, and here we're talking about mostly set path,
plus ensuring min length on the XCom get makes sense too (as that API end point
cant return multiple values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
