ashb commented on code in PR #46926:
URL: https://github.com/apache/airflow/pull/46926#discussion_r1965513180
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -291,8 +291,7 @@ def _process_workloads(self, workloads:
list[workloads.All]) -> None:
key = w.ti.key # type: ignore[union-attr]
queue = w.ti.queue # type: ignore[union-attr]
- # TODO: will be handled by
https://github.com/apache/airflow/issues/46892
- executor_config = {} # type: ignore[var-annotated]
+ executor_config = w.ti.executor_config or {} # type:
ignore[union-attr]
Review Comment:
Instead of the "ignore[union-attr]" we should do a type check and fail if
`w` isn't ExecuteTask. Drive by refactor :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
