amoghrajesh commented on code in PR #46944:
URL: https://github.com/apache/airflow/pull/46944#discussion_r1965570145
##########
tests/executors/test_executor_loader.py:
##########
@@ -68,7 +68,13 @@ def test_no_executor_configured(self):
)
def test_should_support_executor_from_core(self, executor_name):
with conf_vars({("core", "executor"): executor_name}):
- executor = executor_loader.ExecutorLoader.get_default_executor()
+ # These executors are deprecated and will be removed in Airflow
3.0 but we still need to support
+ # them in Airflow 2.10.X
+ if executor_name == "CeleryKubernetesExecutor":
+ with pytest.warns(RemovedInAirflow3Warning):
+ executor =
executor_loader.ExecutorLoader.get_default_executor()
Review Comment:
LocalK8s also?
##########
newsfragments/46944.significant.rst:
##########
@@ -0,0 +1,3 @@
+Statically-coded executors are now deprecated
+
+The Statically-coded executors ``LocalKubernetesExecutor`` and
``CeleryKubernetesExecutor`` are now deprecated in favor of Multiple Executor
Configuration. They will be removed in Airflow 3.0
Review Comment:
Nice! Not breaking but significant for sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
