jedcunningham commented on code in PR #46974: URL: https://github.com/apache/airflow/pull/46974#discussion_r1965981628
########## docs/apache-airflow/administration-and-deployment/web-stack.rst: ########## @@ -0,0 +1,34 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + + +Web Stack +========= + +Sometimes you will want to deploy the backend and the frontend behind a +variable url path prefix. To do so you can configure the url :ref:`config:fastapi__base_url` +for instance set it to ``http://localhost:29091/d12345``. Be sure to reload the +fastapi server for the config update to take effect. All the APIs routes will +now be available through that additional ``d12345`` prefix. + +Without rebuilding the frontend, XHR requests and static file queries should be +directed to the prefixed url and served successfully. + +You will also need to update the execution api server url +:ref:`config:executor__execution_api_server_url` for executors to be able to reach the api Review Comment: ```suggestion :ref:`config:core__execution_api_server_url` for executors to be able to reach the api ``` ########## docs/apache-airflow/administration-and-deployment/web-stack.rst: ########## @@ -0,0 +1,34 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + + +Web Stack +========= + +Sometimes you will want to deploy the backend and the frontend behind a +variable url path prefix. To do so you can configure the url :ref:`config:fastapi__base_url` +for instance set it to ``http://localhost:29091/d12345``. Be sure to reload the +fastapi server for the config update to take effect. All the APIs routes will +now be available through that additional ``d12345`` prefix. + +Without rebuilding the frontend, XHR requests and static file queries should be +directed to the prefixed url and served successfully. + +You will also need to update the execution api server url +:ref:`config:executor__execution_api_server_url` for executors to be able to reach the api Review Comment: ```suggestion :ref:`config:executor__execution_api_server_url` for tasks to be able to reach the api ``` Saying "tasks" might be more easily understood for deployment managers than "workloads", even if thats technically correct. Executors definitely isn't though. ########## docs/apache-airflow/administration-and-deployment/web-stack.rst: ########## @@ -0,0 +1,34 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + + +Web Stack +========= + +Sometimes you will want to deploy the backend and the frontend behind a +variable url path prefix. To do so you can configure the url :ref:`config:fastapi__base_url` +for instance set it to ``http://localhost:29091/d12345``. Be sure to reload the +fastapi server for the config update to take effect. All the APIs routes will Review Comment: ```suggestion for instance set it to ``http://localhost:29091/d12345``. All the APIs routes will ```p My 2c, you can leave this out. No expectation these are hot reloaded. ########## docs/apache-airflow/administration-and-deployment/web-stack.rst: ########## @@ -0,0 +1,34 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + + +Web Stack +========= + +Sometimes you will want to deploy the backend and the frontend behind a +variable url path prefix. To do so you can configure the url :ref:`config:fastapi__base_url` +for instance set it to ``http://localhost:29091/d12345``. Be sure to reload the +fastapi server for the config update to take effect. All the APIs routes will +now be available through that additional ``d12345`` prefix. + +Without rebuilding the frontend, XHR requests and static file queries should be Review Comment: Even saying "rebuilding" is going to get people concerned here haha. I'd probably just add this into the last line of the previous paragraph. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
