bbovenzi commented on PR #46939: URL: https://github.com/apache/airflow/pull/46939#issuecomment-2675236172
> Thanks for bringing back the grid view. I tried the PR locally. Couple of suggestions from my end. > > 1. The presence of titles dag, dag run, etc makes the breadcrumb little misaligned at first look personally. The Airflow 2 UI doesn't have titles and I think it will be good to remove them making the breadcrumb cleaner. > 2. There could be a minimum width to the panel. Scrolling all the way to left causes the grid to render above task ids. Airflow 2 had some minimum width > 3. There could be a full screen button for each panel so that views like graph and right panel can be toggled to utilize the full screen space. Airflow 2 had feature where one can click on a dagrun, select full screen to have only the column and go through all the details in the right pane for the dagrun. > 4. Trigger dag doesn't refresh the grid. Clearing a run and marking the dagrun updates the breadcrumb but grid is not refreshed. > 5. Next run after and schedule value being always displayed in the top right was useful in Airflow 2 irrespective of the view. This seems to be present only on selecting the dag page. > 6. Task instance state color legend could also be presented. 1. I was back and forth on this one. I heard a lot of comments from users that they didn't know what the breadcrumbs were so I wanted to figure out some way to make it more obvious. 2. Yes, I noticed that overflow. Its on my to-do list. 3. Yes, I think I'll do full screen in a follow up PR. This one was already getting big. 4. That is a bug I need to fix. 5. Hmm let me figure out where that could fit in the page. Not going to be for this PR. 6. Yes, in a follow up PR we will need a legend for task instance state icon+color -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
