jedcunningham commented on code in PR #46959:
URL: https://github.com/apache/airflow/pull/46959#discussion_r1966646709


##########
airflow/models/backfill.py:
##########
@@ -335,15 +353,21 @@ def _create_backfill_dag_run(
         except IntegrityError:
             log.info(
                 "Skipped creating backfill dag run for dag_id=%s 
backfill_id=%s, logical_date=%s (already exists)",
-                dr.dag_id,
-                dr.id,
+                dag.dag_id,
+                backfill_id,
                 info.logical_date,
             )
-            log.info("Doing session rollback.")
-            session.rollback()
+            log.info("rolling back")

Review Comment:
   Do we need 2 logs? Can we just wrap this into the previous info? This one 
feels a bit sparse.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to