tirkarthi commented on PR #46968: URL: https://github.com/apache/airflow/pull/46968#issuecomment-2676659899
> Great idea! I've been wanting to make the dashboard link to more parts of the UI > > A few comments. > > We could probably move all the task instance filters into a separate component. And move `TaskInstances` into its own folder. > > And if we refactor that. We should probably fix the Search Tasks button to not have the same hotkey as search dags since they conflict in the Dag Details page Thanks, moved the filter and search to a separate component by creating `TaskInstances` directory. Regarding hotkey issue I guess both "search dags" and "search tasks" have same `SearchBar` component. Task instances list page inside a dagrun is one of those pages where both "search dags" and "search tasks" are present on same page with same hotkey. I am not sure the refactor might help. I can think of below two solutions. 1. Have "hotkey" as a parameter that can be passed to `SearchBar` defaulting to `Ctrl+k`. 2. Make "hotkey" to be enabled/disabled as a boolean and not to add hotkey when the task instances page is rendered inside a dagrun by looking for dagId and runId in URL params. To have hotkey only enabled for tasks on global task instances page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
