nevcohen commented on code in PR #46997:
URL: https://github.com/apache/airflow/pull/46997#discussion_r1967849109
##########
providers/trino/tests/system/trino/example_trino.py:
##########
@@ -36,35 +36,36 @@
with models.DAG(
dag_id="example_trino",
schedule="@once", # Override to match your needs
- start_date=datetime(2022, 1, 1),
+ start_date=datetime(2025, 2, 24),
catchup=False,
tags=["example"],
) as dag:
trino_create_schema = SQLExecuteQueryOperator(
task_id="trino_create_schema",
- sql=f"CREATE SCHEMA IF NOT EXISTS {SCHEMA} WITH (location =
's3://irisbkt/cities/');",
+ sql=f" CREATE SCHEMA IF NOT EXISTS {SCHEMA} WITH (location =
's3://irisbkt/cities/') ",
Review Comment:
Why did you change the format of the sql?
##########
providers/common/sql/tests/unit/common/sql/operators/test_sql.py:
##########
@@ -149,6 +150,21 @@ def test_dont_xcom_push(self, mock_get_db_hook,
mock_process_output):
)
mock_process_output.assert_not_called()
+ @mock.patch.object(SQLExecuteQueryOperator, "_process_output")
+ @mock.patch.object(SQLExecuteQueryOperator, "get_db_hook")
+ def test_requires_result_fetch(self, mock_get_db_hook,
mock_process_output):
Review Comment:
Add to the test `test_do_xcom_push` a pytest parameterize that
`requires_result_fetch` once is true and once false, we should get the same
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
