bugraoz93 commented on code in PR #47004:
URL: https://github.com/apache/airflow/pull/47004#discussion_r1968104606
##########
airflow/configuration.py:
##########
@@ -1249,7 +1251,7 @@ def read_dict( # type: ignore[override]
"""
super().read_dict(dictionary=dictionary, source=source)
- def has_option(self, section: str, option: str,
lookup_from_deprecated_options: bool = True) -> bool:
+ def has_option(self, section: str, option: str, lookup_from_deprecated:
bool = True) -> bool:
Review Comment:
Could you please add the parameter (`lookup_from_deprecated`) to the method
doc as well?
`:param lookup_from_deprecated: ...`
It is already missing but since the name is also changing maybe, good to
include a description here of what that parameter is controlling and when to
pass it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
