github-advanced-security[bot] commented on code in PR #46503:
URL: https://github.com/apache/airflow/pull/46503#discussion_r1968272025
##########
airflow/dag_processing/bundles/git.py:
##########
@@ -143,15 +147,40 @@
super().__init__(**kwargs)
self.tracking_ref = tracking_ref
self.subdir = subdir
- self.bare_repo_path = self._dag_bundle_root_storage_path / "git" /
self.name
- self.repo_path = (
- self._dag_bundle_root_storage_path / "git" / (self.name +
f"+{self.version or self.tracking_ref}")
- )
+ self.bare_repo_path = self.base_folder / "bare"
+ if self.version:
+ self.repo_path = self.versions_path / self.version
+ else:
+ self.repo_path = self.base_folder / "tracking_repo"
self.git_conn_id = git_conn_id
self.repo_url = repo_url
+
+ def log_debug(msg, **kwargs):
+ if not log.isEnabledFor(logging.DEBUG):
+ return
+ # ugly; replace when structlog implemented
+ context = dict(
+ bundle_name=self.name,
+ bundle_type=self.bundle_type,
+ version=self.version,
+ bare_repo_path=self.bare_repo_path,
+ repo_path=self.repo_path,
+ versions_path=self.versions_path,
+ git_conn_id=self.git_conn_id,
+ repo_url=self.repo_url,
+ **kwargs,
+ )
+
+ for k, v in context.items():
+ msg += f" {k}='{v}'"
+ log.debug(msg)
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
This expression logs [sensitive data (password)](2) as clear text.
This expression logs [sensitive data (password)](3) as clear text.
This expression logs [sensitive data (password)](4) as clear text.
This expression logs [sensitive data (secret)](5) as clear text.
This expression logs [sensitive data (secret)](6) as clear text.
This expression logs [sensitive data (password)](7) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/367)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
