shubhamraj-git commented on code in PR #47037:
URL: https://github.com/apache/airflow/pull/47037#discussion_r1968374976
##########
airflow/ui/src/layouts/Details/NavTabs.tsx:
##########
@@ -39,7 +53,7 @@ export const NavTabs = ({ keepSearch, rightButtons, tabs }:
Props) => {
to={{
pathname: value,
// Preserve search params when navigating
- search: keepSearch ? searchParams.toString() : undefined,
+ search: getUpdatedSearchParams(),
}}
Review Comment:
@bbovenzi Was there any specific reason to preserve it? For now, I have
removed the sort from it due to breaking of UI on tabs change when we have
sorting implemented. If it don't have much significant, removing it would be
okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
