aritra24 commented on code in PR #46348:
URL: https://github.com/apache/airflow/pull/46348#discussion_r1968898721
##########
airflow/ui/src/components/ActionAccordion/ActionAccordion.tsx:
##########
@@ -29,13 +29,14 @@ import { columns } from "./columns";
type Props = {
readonly affectedTasks?: TaskInstanceCollectionResponse;
readonly note: DAGRunResponse["note"];
- readonly setNote: (value: string) => void;
+ readonly setNote: ((value: string) => void) | undefined;
};
// Table is in memory, pagination and sorting are disabled.
// TODO: Make a front-end only unconnected table component with client side
ordering and pagination
const ActionAccordion = ({ affectedTasks, note, setNote }: Props) => {
const showTaskSection = affectedTasks !== undefined;
+ const showNoteSection = note !== null;
Review Comment:
Hey @pierrejeambrun, a miss from me, while I was trying to use this to
display backfills I thought the add not was happening at a different place so
thought if there were no notes we wouldn't want to show an empty section. I can
revert it back since I ended up not using the accordion in my dialog box.
Thanks for pointing it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
