jason810496 commented on code in PR #45961: URL: https://github.com/apache/airflow/pull/45961#discussion_r1969264193
########## newsfragments/45961.significant.rst: ########## @@ -0,0 +1,13 @@ +Replace the ``external_trigger`` check with ``DagRunType``, and update any logic that relies on ``external_trigger`` to use ``run_type`` instead. + + +* Types of change + + * [ ] Dag changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency changes + * [x] Code interface changes Review Comment: > Oops, missing migration rules here. Hi @Lee-W, do you mean we should add example for migrating `external_trigger` with `DagRunType` ? I have run `check-significant-newsfragments-are-valid` pre-commit successfully. ########## newsfragments/45961.significant.rst: ########## @@ -0,0 +1,13 @@ +Replace the ``external_trigger`` check with ``DagRunType``, and update any logic that relies on ``external_trigger`` to use ``run_type`` instead. + + +* Types of change + + * [ ] Dag changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency changes + * [x] Code interface changes Review Comment: > Oops, missing migration rules here. Hi @Lee-W, do you mean we should add example for migrating `external_trigger` with `DagRunType` ? I have run `check-significant-newsfragments-are-valid` pre-commit successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
