ashb commented on code in PR #47041:
URL: https://github.com/apache/airflow/pull/47041#discussion_r1970090063
##########
airflow/auth/managers/simple/ui/src/login/Login.tsx:
##########
@@ -36,7 +36,7 @@ type ExpandedApiError = {
export const Login = () => {
const onSuccess = (data: LoginResponse) => {
// Redirect to index page with the token
- globalThis.location.replace(`/webapp/?token=${data.jwt_token}`);
+ globalThis.location.replace(`/?token=${data.jwt_token}`);
Review Comment:
I also have a question about why we are putting the JWT token in a query
param, which means it gets sent and shows up in server access logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
