Lee-W commented on code in PR #45960:
URL: https://github.com/apache/airflow/pull/45960#discussion_r1969780754
##########
task_sdk/src/airflow/sdk/api/client.py:
##########
@@ -445,6 +466,12 @@ def assets(self) -> AssetOperations:
"""Operations related to Assets."""
return AssetOperations(self)
+ @lru_cache() # type: ignore[misc]
+ @property
Review Comment:
If we want to change it (if it works), we probably would like to change it
in another PR so I'm going to resolve this one
##########
airflow/api_fastapi/execution_api/datamodels/asset_event.py:
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+from datetime import datetime
+
+from pydantic import Field, field_validator
+
+from airflow.api_fastapi.core_api.base import BaseModel, StrictBaseModel
+from airflow.sdk.execution_time.secrets_masker import redact
+
+
+class DagRunAssetReference(StrictBaseModel):
+ """DAGRun serializer for asset responses."""
+
+ run_id: str
+ dag_id: str
+ logical_date: datetime | None
+ start_date: datetime
+ end_date: datetime | None
+ state: str
+ data_interval_start: datetime | None
+ data_interval_end: datetime | None
+
+
+class AssetEventResponse(BaseModel):
+ """Asset event schema with fields that are needed for Runtime."""
+
+ id: int
+ asset_id: int
+ uri: str | None = Field(alias="uri", default=None)
+ name: str | None = Field(alias="name", default=None)
+ group: str | None = Field(alias="group", default=None)
+ extra: dict | None = None
+ source_task_id: str | None = None
+ source_dag_id: str | None = None
+ source_run_id: str | None = None
+ source_map_index: int = -1
Review Comment:
I'll mark it as resolved for now.
##########
airflow/api_fastapi/execution_api/datamodels/asset_event.py:
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+from datetime import datetime
+
+from pydantic import Field, field_validator
+
+from airflow.api_fastapi.core_api.base import BaseModel, StrictBaseModel
+from airflow.sdk.execution_time.secrets_masker import redact
+
+
+class DagRunAssetReference(StrictBaseModel):
+ """DAGRun serializer for asset responses."""
+
+ run_id: str
+ dag_id: str
+ logical_date: datetime | None
+ start_date: datetime
+ end_date: datetime | None
+ state: str
+ data_interval_start: datetime | None
+ data_interval_end: datetime | None
+
+
+class AssetEventResponse(BaseModel):
+ """Asset event schema with fields that are needed for Runtime."""
+
+ id: int
+ asset_id: int
+ uri: str | None = Field(alias="uri", default=None)
+ name: str | None = Field(alias="name", default=None)
+ group: str | None = Field(alias="group", default=None)
Review Comment:
got it. I thought we want these exposed object in definitions, but yep,
makes sense. Will update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
