jedcunningham commented on code in PR #46694: URL: https://github.com/apache/airflow/pull/46694#discussion_r1970861110
########## providers/common/messaging/docs/changelog.rst: ########## @@ -0,0 +1,35 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +.. NOTE TO CONTRIBUTORS: + Please, only add notes to the Changelog just below the "Changelog" header when there are some breaking changes + and you want to add an explanation to the users on how they are supposed to deal with them. + The changelog is updated and maintained semi-automatically by release manager. + +``apache-airflow-providers-common-messaging`` + +Changelog +--------- + +1.0.0 +..... + +.. note:: + This release of provider is only available for Airflow 2.9+ as explained in the Review Comment: This doesn't match the 3.0+ requirement. ########## providers/common/messaging/tests/system/common/messaging/example_message_queue_trigger.py: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.models.baseoperator import chain +from airflow.models.dag import DAG +from airflow.providers.common.messaging.triggers.msg_queue import MessageQueueTrigger +from airflow.providers.standard.operators.empty import EmptyOperator +from airflow.sdk.definitions.asset import Asset, AssetWatcher + +# [START howto_trigger_message_queue] +trigger = MessageQueueTrigger(queue="https://sqs.us-east-1.amazonaws.com/0123456789/my-queue";) +asset = Asset("sqs_asset", watchers=[AssetWatcher(name="sqs_asset_watcher", trigger=trigger)]) + +with DAG( + dag_id="example_msgq_watcher", + schedule=[asset], + catchup=False, +): + task = EmptyOperator(task_id="task") + + chain(task) Review Comment: ```suggestion EmptyOperator(task_id="task") ``` No need for a var and chain if there is a single task. ########## providers/common/messaging/tests/system/common/messaging/example_message_queue_trigger.py: ########## Review Comment: This feels a little weird being in the test dir? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
