vincbeck commented on PR #47099: URL: https://github.com/apache/airflow/pull/47099#issuecomment-2685347172
> @vincbeck > > I can do it, but could you suggest what to check? [The current test](https://github.com/apache/airflow/blob/main/providers/amazon/tests/unit/amazon/aws/operators/test_bedrock.py#L335) is pretty simple Indeed :) It is pretty simple. Ideally we want to test the `execute` function. In an ideal world we would like to test different branches such as when `wait_for_completion` is `True`, when `wait_for_completion` is `False`, same for `deferrable` but given this is not your code change, at least one test covering the case when `wait_for_completion` is `True` and `deferrable` is `False` would suffice. You can check that `get_waiter` has been called once with the given parameters. If you look at other tests you can find aspiration, this is pretty standard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
