jedcunningham commented on code in PR #46942:
URL: https://github.com/apache/airflow/pull/46942#discussion_r1972235753
##########
Dockerfile.ci:
##########
@@ -1016,46 +974,6 @@ function check_airflow_python_client_installation() {
python "${IN_CONTAINER_DIR}/install_airflow_python_client.py"
}
-function start_webserver_with_examples(){
Review Comment:
Shouldn't this start using the api server, instead of being removed
completely?
##########
airflow/settings.py:
##########
@@ -707,21 +705,6 @@ def initialize():
# instances
MASK_SECRETS_IN_LOGS = False
-# Display alerts on the dashboard
-# Useful for warning about setup issues or announcing changes to end users
-# List of UIAlerts, which allows for specifying the message, category, and
roles the
-# message should be shown to. For example:
-# from airflow.www.utils import UIAlert
-#
-# DASHBOARD_UIALERTS = [
-# UIAlert("Welcome to Airflow"), # All users
-# UIAlert("Airflow update happening next week", roles=["User"]), # Only
users with the User role
-# # A flash message with html:
-# UIAlert('Visit <a
href="http://airflow.apache.org";>airflow.apache.org</a>', html=True),
-# ]
-#
-DASHBOARD_UIALERTS: list[UIAlert] = []
Review Comment:
Opened #47121 so we can make this this gets added back into the new UI.
##########
providers/fab/src/airflow/providers/3rd-party-licenses/LICENSES-ui.txt:
##########
Review Comment:
Should this go in
providers/fab/src/airflow/providers/fab/3rd-party-licenses/LICENSES-ui.txt
(added fab in the middle there)?
##########
airflow/utils/airflow_flask_app.py:
##########
Review Comment:
Shouldn't this whole file go away?
##########
tests/plugins/test_plugins_manager.py:
##########
@@ -73,95 +72,6 @@ def wrapper(*args, **kwargs):
return wrapper
[email protected]_test
-class TestPluginsRBAC:
Review Comment:
Hmm, don't we need to keep these? This is still in the plugin interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
