pierrejeambrun commented on code in PR #47136:
URL: https://github.com/apache/airflow/pull/47136#discussion_r1975728287
##########
tests/api_fastapi/conftest.py:
##########
@@ -98,6 +142,7 @@ def make_dag_with_multiple_versions(dag_maker,
configure_git_connection_for_dag_
logical_date=datetime.datetime(2020, 1, version_number,
tzinfo=datetime.timezone.utc),
dag_version=DagVersion.get_version(dag_id=dag_id,
version_number=version_number),
)
+ session.commit()
Review Comment:
`dag.sync_to_db()` just put it at the end of each loop, should be enough
##########
tests/api_fastapi/core_api/routes/public/test_assets.py:
##########
@@ -990,6 +1058,7 @@ def create_dags(self, setup, dag_maker, session):
EmptyOperator(task_id="task", outlets=assets[2])
with dag_maker(self.DAG_ASSET_NO, schedule=None, session=session):
EmptyOperator(task_id="task")
+ session.commit()
Review Comment:
I think so yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
