jason810496 commented on PR #47062: URL: https://github.com/apache/airflow/pull/47062#issuecomment-2691894938
> maybe changing the client fixture to a context manager updated the pytest fixture resolution order, in such a way that we were lucky before, a fixture with a commit appeared later than the create_dags one and was hidding the issue ? I think that is the only way to illustrate this wired error, thanks for the explanation ! > Basically fixture creating db objects should commit. (or not commit if the helper code they call do the commit for them) Thanks to point out, so that we should commit explicitly when using `session` fixture. Maybe, the test I wrote with before utilize `provide_session` decorator, it will `commit` at the end of context, so I won't add `commit` explicitly in test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
