pierrejeambrun commented on code in PR #46981:
URL: https://github.com/apache/airflow/pull/46981#discussion_r1977361093
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -102,21 +102,21 @@ def deserialize_user(self, token: dict[str, Any]) -> T:
"""Create a user object from dict."""
@abstractmethod
- def serialize_user(self, user: T) -> dict[str, Any]:
- """Create a dict from a user object."""
+ def serialize_user(self, user: T) -> tuple[str, dict[str, Any]]:
+ """Create a subject and extra claims dict from a user object."""
Review Comment:
Could the auth api use an anonymous user ? or a technical user ? Anyway if
the current works, it's fine.
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -102,21 +102,21 @@ def deserialize_user(self, token: dict[str, Any]) -> T:
"""Create a user object from dict."""
@abstractmethod
- def serialize_user(self, user: T) -> dict[str, Any]:
- """Create a dict from a user object."""
+ def serialize_user(self, user: T) -> tuple[str, dict[str, Any]]:
+ """Create a subject and extra claims dict from a user object."""
Review Comment:
Could the auth api use an anonymous user ? or a technical user ? Anyway if
the current form works, it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
