dstandish commented on code in PR #47187:
URL: https://github.com/apache/airflow/pull/47187#discussion_r1977943898
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -834,6 +834,8 @@ def trigger_reentry(self, context: Context, event:
dict[str, Any]) -> Any:
last_log_time = event.get("last_log_time")
if event["status"] in ("error", "failed", "timeout"):
+ if event["status"] == "error":
+ self.log.error("Trigger emitted an error event, failing
the task: %s", event["message"])
Review Comment:
Since we unconditionally raise after this point, why only log in the `error`
case?
I would just say `trigger exited with status {status}; failing the task` or
something -- no matter the status. might as well cover all the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
