bugraoz93 commented on PR #47186: URL: https://github.com/apache/airflow/pull/47186#issuecomment-2695455694
> Thank you @bugraoz93 for the direction! This makes total sense! I'm new to contributing to Airflow -- is there any provider example I can follow to add tests? The tests depend on the case and in this case, I believe it should be under `providers/presto/tests/unit/presto/hooks/test_presto.py`. If you would like specific examples, please take a look at them here. I believe there are examples where `file_name` is None or filled means overload in this context. So in your case, those overloads should be covered in tests according to their behaviours in the code Code https://github.com/apache/airflow/blob/201baf902abbdb392f86d0c65e0def6d2fc1783b/providers/google/src/airflow/providers/google/cloud/hooks/gcs.py#L283-L409 Tests https://github.com/apache/airflow/blob/4651ccce787b33af9ea03f43a876538d806ac68a/providers/google/tests/unit/google/cloud/hooks/test_gcs.py#L840-L913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
