o-nikolas commented on code in PR #47035:
URL: https://github.com/apache/airflow/pull/47035#discussion_r1980156291
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/mwaa.py:
##########
@@ -56,30 +64,78 @@ def invoke_rest_api(
:param env_name: name of the MWAA environment
:param path: Apache Airflow REST API endpoint path to be called
- :param method: HTTP method used for making Airflow REST API calls
+ :param method: HTTP method used for making Airflow REST API calls:
'GET'|'PUT'|'POST'|'PATCH'|'DELETE'
:param body: Request body for the Apache Airflow REST API call
:param query_params: Query parameters to be included in the Apache
Airflow REST API call
+ :param only_use_web_login: If True, only the web login method is used
without trying boto's
Review Comment:
I'm not sure the `only` is required here, honestly. I think if you say
`generate_local_token=True` the user expectation is that it will do just that.
And you can expand on that in the param description as you are. But also I'm
happy to disagree and commit on this one! :smiley:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
