pierrejeambrun commented on code in PR #47062:
URL: https://github.com/apache/airflow/pull/47062#discussion_r1981170894
##########
airflow/api_fastapi/common/db/common.py:
##########
@@ -155,10 +155,10 @@ def paginated_select(
def paginated_select(
*,
statement: Select,
- filters: Sequence[BaseParam] | None = None,
- order_by: BaseParam | None = None,
- offset: BaseParam | None = None,
- limit: BaseParam | None = None,
+ filters: Sequence[OrmFilterClause] | None = None,
+ order_by: OrmFilterClause | None = None,
Review Comment:
nit: `OrmFilterClause` you should remove the `Filter` -> `OrmClause` because
`limits` `offsets` etc are not considered `filtered` on the sqlalchemy part.
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -260,6 +271,7 @@ def patch_dags(
only_active: QueryOnlyActiveFilter,
paused: QueryPausedFilter,
last_dag_run_state: QueryLastDagRunStateFilter,
+ editable_dag_filter: EditableDagsFilterDep,
Review Comment:
```suggestion
editable_dags_filter: EditableDagsFilterDep,
```
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -131,6 +137,7 @@ def get_dags(
tags,
owners,
last_dag_run_state,
+ readable_dag_filter,
Review Comment:
```suggestion
readable_dags_filter,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
