jedcunningham commented on code in PR #47371:
URL: https://github.com/apache/airflow/pull/47371#discussion_r1981746747
##########
airflow/cli/commands/remote_commands/config_command.py:
##########
@@ -227,6 +227,21 @@ def message(self) -> str:
suggestion="Remove TaskContextLogger: Replaced by the Log table for
better handling of task log "
"messages outside the execution context.",
),
+ ConfigChange(
+ config=ConfigParameter("logging", "log_filename_template"),
Review Comment:
Will this hit regardless of the value? Not sure that's what we want.
##########
airflow/cli/commands/remote_commands/config_command.py:
##########
@@ -227,6 +227,21 @@ def message(self) -> str:
suggestion="Remove TaskContextLogger: Replaced by the Log table for
better handling of task log "
"messages outside the execution context.",
),
+ ConfigChange(
+ config=ConfigParameter("logging", "log_filename_template"),
+ suggestion=(
+ "The default value in Airflow 2 (e.g., '{{ ti.dag_id }}/{{
ti.task_id }}/{{ ts }}/{{ try_number }}.log') "
+ "breaks task logs in the new UI. Please update to the new
recommended format as per "
+
"https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#log-filename-template.";
+ ),
+ was_deprecated=False,
+ ),
+ ConfigChange(
+ config=ConfigParameter("logging", "log_processor_filename_template"),
Review Comment:
Looks down a few lines, this config is already removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
