jscheffl commented on code in PR #47322:
URL: https://github.com/apache/airflow/pull/47322#discussion_r1982235120
##########
tests/utils/test_log_handlers.py:
##########
@@ -209,8 +207,6 @@ def task_callable(ti):
{
("core", "EXECUTOR"): ",".join(
[
- executor_constants.LOCAL_KUBERNETES_EXECUTOR,
- executor_constants.CELERY_KUBERNETES_EXECUTOR,
executor_constants.KUBERNETES_EXECUTOR,
]
),
Review Comment:
Probably this can be reduced to a single line as we do not need to "join" a
single list element array.
##########
airflow/settings.py:
##########
@@ -687,11 +687,7 @@ def initialize():
LAZY_LOAD_PROVIDERS: bool = conf.getboolean("core", "lazy_discover_providers",
fallback=True)
# Determines if the executor utilizes Kubernetes
-IS_K8S_OR_K8SCELERY_EXECUTOR = conf.get("core", "EXECUTOR") in {
- executor_constants.KUBERNETES_EXECUTOR,
- executor_constants.CELERY_KUBERNETES_EXECUTOR,
- executor_constants.LOCAL_KUBERNETES_EXECUTOR,
-}
+IS_K8S_OR_K8SCELERY_EXECUTOR = conf.get("core", "EXECUTOR") ==
executor_constants.KUBERNETES_EXECUTOR
Review Comment:
First time that I see this variable - wondering if this would work with
multiple executors today... so if you use K8sExecutor and Celery together...
then you do not equal. But anyway probably not relevant for this PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
