uranusjr commented on code in PR #47282:
URL: https://github.com/apache/airflow/pull/47282#discussion_r1982555580
##########
airflow/models/taskinstance.py:
##########
@@ -947,7 +947,7 @@ def get_prev_start_date_success() -> pendulum.DateTime |
None:
def get_prev_end_date_success() -> pendulum.DateTime | None:
return
timezone.coerce_datetime(_get_previous_dagrun_success().end_date)
- def get_triggering_events() -> dict[str, list[AssetEvent]]:
+ def get_triggering_events() -> dict[Asset, list[AssetEvent]]:
Review Comment:
I wonder if we should use a custom mapping class like `OutletEventAccessors`
so we can accept AssetRef here; it is a bit clunky for users to need to pass in
the original asset object to get events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
